[PENDING] fix(svg): use textBaseline
specified in text style instead of fixed default value.
#763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A PENDING CHANGE
I noticed the text node's position rendered by the SVG renderer currently differs from the canvas renderer.
Here are some cases,
I'm not sure about the reason for setting the
dominant-baseline
attribute of the text node as a fixedmiddle
(previously) orcentral
(currently) in SVG renderer, but if we usetextBaseline
specified in text style, it will render the text as the same as the canvas renderer. At least, it will look quite obviously better than now.