migrate distributed tracing flags off experimental prefix

[omerap12]

Fixes: #19050
Move distributed tracing related flags:

• experimental-enable-distributed-tracing
• experimental-distributed-tracing-address
• experimental-distributed-tracing-service-name
• experimental-distributed-tracing-instance-id
• experimental-distributed-tracing-sampling-rate

The experimental flags are marked as deprecated and will be decommissioned in v3.7.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[k8s-ci-robot]

Hi @omerap12. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[serathius]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (e30a4ab) to head (d502e91).
Report is 20 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/embed/config.go	79.65% <100.00%> (+0.22%)	⬆️
server/etcdmain/config.go	68.98% <100.00%> (+1.22%)	⬆️

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19096      +/-   ##
==========================================
- Coverage   68.82%   68.74%   -0.08%     
==========================================
  Files         420      420              
  Lines       35640    35653      +13     
==========================================
- Hits        24528    24511      -17     
- Misses       9692     9708      +16     
- Partials     1420     1434      +14     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30a4ab...d502e91. Read the comment docs.

[omerap12]

Hey @serathius, I’m running into some issues with gofumpt 😄

[siyuanfoundation]

use mustCreateCfgFile

[omerap12]

Added in 9448afd

[serathius]

Hey @serathius, I’m running into some issues with gofumpt 😄

Can you run make fix-lint?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[omerap12]

Hey @serathius, I’m running into some issues with gofumpt 😄

Can you run make fix-lint?

Fixed, thanks!

[siyuanfoundation]

can you also update references to ExperimentalEnableDistributedTracing in other places like server/embed/etcd.go and server/etcdserver/api/v3rpc/grpc.go?
And the parameters like ExperimentalEnableDistributedTracing in server/config/config.go needs to be updated.