-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable use-any rule from revive #19120
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 31 files with indirect coverage changes @@ Coverage Diff @@
## main #19120 +/- ##
==========================================
+ Coverage 68.79% 68.84% +0.04%
==========================================
Files 420 420
Lines 35640 35649 +9
==========================================
+ Hits 24520 24541 +21
+ Misses 9696 9686 -10
+ Partials 1424 1422 -2 Continue to review full report in Codecov by Sentry.
|
Let's try not overdo this. There are huge numbers of
Looks good. |
@ahrtr , |
Search |
Yes by default golangci lint is not applied on generated files so this PR is already complete and won't require other changes |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matthieu MOREL <[email protected]>
ae6749c
to
ea50139
Compare
Description
enable use-any rule from revive
Also sort revive rules alphabetically