Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traits.h: Fix feature-test macro for P1144 trivial relocatability #2314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Traits.h: Fix feature-test macro for P1144 trivial relocatability #2314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Traits.h: Fix feature-test macro for P1144 trivial relocatability 
Well, this is awkward. #2216 added this `#if` check, but with the
wrong macro: `__cpp_lib_is_trivially_relocatable` should have been
`__cpp_lib_trivially_relocatable`.
  • Loading branch information
@Quuxplusone
Quuxplusone committed Oct 12, 2024
commit 4c333ebada01f2235adc7a3901b67843ad2ae358
2 changes: 1 addition & 1 deletion folly/Traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ struct IsRelocatable
!require_sizeof<T> ||
is_detected_v<traits_detail::detect_IsRelocatable, T>,
traits_detail::has_true_IsRelocatable<T>,
#if defined(__cpp_lib_is_trivially_relocatable) // P1144
#if defined(__cpp_lib_trivially_relocatable) // P1144
std::is_trivially_relocatable<T>
#else
std::is_trivially_copyable<T>
Expand Down
Loading