Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node.js attribution to LICENSE #355

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Add node.js attribution to LICENSE #355

merged 1 commit into from
Mar 2, 2024

Conversation

chjj
Copy link
Contributor

@chjj chjj commented Mar 1, 2024

Should cover any node.js code we decide to re-use (primarily for test/node right now).

dcousens
dcousens approved these changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcousens dcousens merged commit 5857e29 into feross:master Mar 2, 2024
6 checks passed
@dcousens
Copy link
Collaborator

dcousens commented Mar 2, 2024 •
edited
Loading

Your question from #348

Okay, after looking, I guess it isn't accounted for. Should I add a the node.js LICENSE file inside the test/node directory, or should I concatenate the existing LICENSE file with the node.js one?

I don't know the history of the project fully, but I think covering this broadly seems conservative and reasonable - the license text is the same, save the copyright headers. I will ping @feross for posterity, but this seems correct to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chjj @dcousens