-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(f3): checkpoint tipsets that are finalized by F3 #12460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/checkpoint-f3-finalized-tipsets
branch
from
September 13, 2024 11:31
5c156a9
to
f293db5
Compare
masih
force-pushed
the
masih/checkpoint-f3-finalized-tipsets
branch
2 times, most recently
from
September 13, 2024 15:09
1ac1011
to
57c549d
Compare
Kubuxu
reviewed
Sep 13, 2024
Stebalien
reviewed
Sep 13, 2024
masih
force-pushed
the
masih/checkpoint-f3-finalized-tipsets
branch
2 times, most recently
from
September 17, 2024 14:45
4e802b2
to
300c240
Compare
Stebalien
reviewed
Sep 17, 2024
masih
force-pushed
the
masih/checkpoint-f3-finalized-tipsets
branch
2 times, most recently
from
September 18, 2024 11:38
0a135c4
to
cca4df1
Compare
Once a decision is received from F3, checkpoint it in chain-store. As part of checkpointing, refactor the F3 tipset wrapper to reduce type casting. Note that go-f3 module now uses Go 1.22, which requires Lotus go module to be updated accordingly. Part of filecoin-project/go-f3#603
masih
force-pushed
the
masih/checkpoint-f3-finalized-tipsets
branch
from
September 18, 2024 12:11
cca4df1
to
31aebd2
Compare
Kubuxu
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to disable the finalize on the mainnet network right now.
masih
force-pushed
the
masih/checkpoint-f3-finalized-tipsets
branch
2 times, most recently
from
September 18, 2024 14:32
a1c82c4
to
6acd2ca
Compare
Stebalien
approved these changes
Sep 18, 2024
masih
force-pushed
the
masih/checkpoint-f3-finalized-tipsets
branch
from
September 18, 2024 15:19
6acd2ca
to
67fc818
Compare
8 tasks
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Once a decision is received from F3, checkpoint it in chain-store. As part of checkpointing, refactor the F3 tipset wrapper to reduce type casting.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: