refactor: UI tweaks #1255
Open
refactor: UI tweaks #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
changed the title
russellwheatley
commented
May 14, 2025
| Divider() | ||
| EmailLinkView() | ||
| } else if authService.authView == .phoneAuth { | ||
| // TODO: - how are we rendering the phone auth View?? |
There was a problem hiding this comment.
This is the nub of the problem and it is the same problem we have rendering the buttons. Core auth package doesn't know about PhoneAuthView so how can we render it?
We could:
- Use AnyView again like with rendering buttons.
- Move Phone Auth package in to Core Auth package - A couple hundred lines of code extra, not a tremendous amount.
- An alternative solution???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2c4dd76(#1255)af59d88(#1255)bf20f0c(#1255)To give you context on Phone Auth, the UI was rendering directly in the AuthPickerView:
The aim was to make it Phone Auth a button so it would make AuthPickerView less cluttered and closer to previous implementation:
The problem we have now is - how do we shift the View to Phone Auth? It has to happen from within Core Auth package (AuthPickerView). See comment for further details: https://github.com/firebase/FirebaseUI-iOS/pull/1255/files#r2088761197
I guess we should bear in mind this is for alpha release at the moment.