BF: No swap fiat value displayed in insufficient balance view #679

[SYhotmail]

fix: No swap fiat value displayed in insufficient balance view #679
ConfirmTransferViewModel.swift: metadata is used, because validate balance will throw if not sufficient funds.

[gemini-code-assist]

Hello @SYhotmail, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses a bug where the swap fiat value was not being displayed in the insufficient balance view. The fix involves ensuring that the metadata is available when the transactionInputViewModel is updated with an error state, which occurs when there are insufficient funds for the swap. This is achieved by initializing metadata before the do block and passing it to the transactionInputViewModel in the catch block for TransferAmountCalculatorError.

Highlights

• Bug Fix: Fixes an issue where the swap fiat value was not displayed in the insufficient balance view.
• Metadata Handling: Ensures that metadata is available and passed to the transactionInputViewModel when an error occurs due to insufficient funds.

Changelog

• Gem/Transfer/ViewsModels/ConfirmTransferViewModel.swift
  • Initializes metadata variable before the do block to ensure it's available in the catch block.
  • Passes the metadata to the transactionInputViewModel when a TransferAmountCalculatorError is caught.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A balance too low,
The fiat value unseen,
Metadata's the key.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses an issue where the swap fiat value was not displayed in the insufficient balance view. The changes involve initializing the metadata variable and passing it to the transactionInputViewModel in the catch block for TransferAmountCalculatorError. Overall, the changes seem reasonable and targeted to fix the reported issue.

Summary of Findings

• Metadata Initialization: The metadata variable is initialized to ensure it's available in the catch block for displaying fiat value in the insufficient balance view.
• Passing Metadata on Error: The metadata is passed to the transactionInputViewModel even when there's an error during transfer amount calculation, ensuring the fiat value can be displayed.

Merge Readiness

The pull request seems to address the issue effectively. The changes are well-targeted and the code is clear. I would recommend adding the comment as suggested above to improve the code's maintainability. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.

[gemini-code-assist]

It's good to see metadata initialized here to avoid potential issues in the catch block. However, consider adding a comment explaining why this initialization is necessary, especially since it's related to handling insufficient funds and the display of fiat value. This will help future developers understand the purpose of this change.

Suggested change

	var metadata: TransferDataMetadata!
	var metadata: TransferDataMetadata! // Initialize to ensure it's available in the catch block for displaying fiat value in insufficient balance view