Skip to content

Structure field: improve disabled UI #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: v5/develop
Choose a base branch
from

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented May 10, 2025

Description

Summary of changes

  • Table remains interactive when field is disabled: can open drawer (where form is disabled) to see all fields, can still paginate
  • Fiber drawer: don't use disabled prop to hide drawers in the drawer stack. Instead using visible prop.
Screen.Recording.2025-05-10.at.18.30.01.mov

Reasoning

https://feedback.getkirby.com/687

Additional context

Since we used the :disabled prop in this way only in k-fiber-drawer, I think the change can be merged without being a breaking change.

Changelog

Enhancements

  • Structure field: improved UI when field is disabled that allows to open drawer to see all fields as well as navigate through all entries when paginated

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative self-assigned this May 10, 2025
@distantnative distantnative added this to the 5.1.0 milestone May 10, 2025
@distantnative distantnative force-pushed the v51/enhancement/structure-field-disabled branch from 4f4140e to f7620b4 Compare May 10, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant