Add windows requierement #3

Stargateur · 2023-09-20T23:55:20Z

look like MCVC 2019 is not enough for this project.

cwfitzgerald

Interesting, what errors do you get on msvc?

In addition to adding it to the Readme, we should explicitly check the msvc version in the build script (using https://docs.rs/cc/latest/cc/windows_registry/fn.find_vs_version.html) and raise an explicit error.

cwfitzgerald · 2023-09-21T02:08:18Z

README.md

@@ -11,6 +11,12 @@ differences, FLIP's comparison can be more meaningful than a simple pixel-wise c
 In order to keep a small dependency closure, this crate does not depend on `image`,
 but interop is simple.

+## Requirement


Let's just make a top level windows section.

README.md

look like MCVC 2019 is not enough for this project.

Stargateur · 2023-09-21T06:58:20Z

I didn't save the error sorry, I think he didn't like auto from C23, I tried to install MSVC 2022 to solve the issue and all run good.

nv-flip-rs/nv-flip-sys/src/bindings.cpp

Line 70 in d532489

auto image = new FlipImageFloat { FLIP::image<float>(width, height) };

Stargateur · 2023-09-21T07:41:24Z

here I uninstall it just for you MSVC 2019 16.2.5:

[nv-flip-sys 0.1.1] TARGET = Some("x86_64-pc-windows-msvc")
[nv-flip-sys 0.1.1] OPT_LEVEL = Some("0")
[nv-flip-sys 0.1.1] HOST = Some("x86_64-pc-windows-msvc")
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX_x86_64-pc-windows-msvc
[nv-flip-sys 0.1.1] CXX_x86_64-pc-windows-msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX_x86_64_pc_windows_msvc
[nv-flip-sys 0.1.1] CXX_x86_64_pc_windows_msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=HOST_CXX
[nv-flip-sys 0.1.1] HOST_CXX = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX
[nv-flip-sys 0.1.1] CXX = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
[nv-flip-sys 0.1.1] CRATE_CC_NO_DEFAULTS = None
[nv-flip-sys 0.1.1] CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
[nv-flip-sys 0.1.1] DEBUG = Some("true")
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS_x86_64-pc-windows-msvc
[nv-flip-sys 0.1.1] CXXFLAGS_x86_64-pc-windows-msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS_x86_64_pc_windows_msvc
[nv-flip-sys 0.1.1] CXXFLAGS_x86_64_pc_windows_msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=HOST_CXXFLAGS
[nv-flip-sys 0.1.1] HOST_CXXFLAGS = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS
[nv-flip-sys 0.1.1] CXXFLAGS = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX_x86_64-pc-windows-msvc
[nv-flip-sys 0.1.1] CXX_x86_64-pc-windows-msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX_x86_64_pc_windows_msvc
[nv-flip-sys 0.1.1] CXX_x86_64_pc_windows_msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=HOST_CXX
[nv-flip-sys 0.1.1] HOST_CXX = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX
[nv-flip-sys 0.1.1] CXX = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
[nv-flip-sys 0.1.1] CRATE_CC_NO_DEFAULTS = None
[nv-flip-sys 0.1.1] CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS_x86_64-pc-windows-msvc
[nv-flip-sys 0.1.1] CXXFLAGS_x86_64-pc-windows-msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS_x86_64_pc_windows_msvc
[nv-flip-sys 0.1.1] CXXFLAGS_x86_64_pc_windows_msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=HOST_CXXFLAGS
[nv-flip-sys 0.1.1] HOST_CXXFLAGS = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS
[nv-flip-sys 0.1.1] CXXFLAGS = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX_x86_64-pc-windows-msvc
[nv-flip-sys 0.1.1] CXX_x86_64-pc-windows-msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX_x86_64_pc_windows_msvc
[nv-flip-sys 0.1.1] CXX_x86_64_pc_windows_msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=HOST_CXX
[nv-flip-sys 0.1.1] HOST_CXX = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX
[nv-flip-sys 0.1.1] CXX = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
[nv-flip-sys 0.1.1] CRATE_CC_NO_DEFAULTS = None
[nv-flip-sys 0.1.1] CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS_x86_64-pc-windows-msvc
[nv-flip-sys 0.1.1] CXXFLAGS_x86_64-pc-windows-msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS_x86_64_pc_windows_msvc
[nv-flip-sys 0.1.1] CXXFLAGS_x86_64_pc_windows_msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=HOST_CXXFLAGS
[nv-flip-sys 0.1.1] HOST_CXXFLAGS = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS
[nv-flip-sys 0.1.1] CXXFLAGS = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX_x86_64-pc-windows-msvc
[nv-flip-sys 0.1.1] CXX_x86_64-pc-windows-msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX_x86_64_pc_windows_msvc
[nv-flip-sys 0.1.1] CXX_x86_64_pc_windows_msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=HOST_CXX
[nv-flip-sys 0.1.1] HOST_CXX = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXX
[nv-flip-sys 0.1.1] CXX = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
[nv-flip-sys 0.1.1] CRATE_CC_NO_DEFAULTS = None
[nv-flip-sys 0.1.1] CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS_x86_64-pc-windows-msvc
[nv-flip-sys 0.1.1] CXXFLAGS_x86_64-pc-windows-msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS_x86_64_pc_windows_msvc
[nv-flip-sys 0.1.1] CXXFLAGS_x86_64_pc_windows_msvc = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=HOST_CXXFLAGS
[nv-flip-sys 0.1.1] HOST_CXXFLAGS = None
[nv-flip-sys 0.1.1] cargo:rerun-if-env-changed=CXXFLAGS
[nv-flip-sys 0.1.1] CXXFLAGS = None
[nv-flip-sys 0.1.1] running: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Tools\\MSVC\\14.22.27905\\bin\\HostX64\\x64\\cl.exe" "-nologo" "-MD" "-Z7" "-Brepro" "-I" "src/" "-I" "extern/cpp/common/" "-I" "extern/cpp/CPP/" "-W4" "/std:c++17" "/permissive-" "-DNOMINMAX" "-FoC:\\Users\\plask\\git\\nv-flip-rs\\target\\debug\\build\\nv-flip-sys-f86ae066846a23b3\\out\\src/bindings.o" "-c" "src/bindings.cpp"
[nv-flip-sys 0.1.1] bindings.cpp
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(70): warning C4201: extension non standard utilis�e�: struct/union sans nom
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(71): warning C4201: extension non standard utilis�e�: struct/union sans nom
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): warning C4201: extension non standard utilis�e�: struct/union sans nom
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(119): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(124): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(129): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(134): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(139): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(144): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(149): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(154): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(159): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(167): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(175): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(183): warning C4458: la d�claration de 'v' masque le membre de classe
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\../CPP/color.h(72): note: voir la d�claration de 'FLIP::color3::<unnamed-tag>::v'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C2039: 'max'�: n'est pas membre de 'std'
[nv-flip-sys 0.1.1] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.22.27905\include\string(19): note: voir la d�claration de 'std'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C2039: 'max'�: n'est pas membre de 'std'
[nv-flip-sys 0.1.1] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.22.27905\include\string(19): note: voir la d�claration de 'std'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C2039: 'max'�: n'est pas membre de 'std'
[nv-flip-sys 0.1.1] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.22.27905\include\string(19): note: voir la d�claration de 'std'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C3861: 'max'�: identificateur introuvable
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C2039: 'max'�: n'est pas membre de 'std'
[nv-flip-sys 0.1.1] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.22.27905\include\string(19): note: voir la d�claration de 'std'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C3861: 'max'�: identificateur introuvable
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C3861: 'max'�: identificateur introuvable
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C2039: 'max'�: n'est pas membre de 'std'
[nv-flip-sys 0.1.1] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.22.27905\include\string(19): note: voir la d�claration de 'std'
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C3861: 'max'�: identificateur introuvable
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\sharedflip.h(70): error C3861: 'max'�: identificateur introuvable
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\common\tinyexr.h(9217): warning C4389: '=='�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] C:\Users\plask\git\nv-flip-rs\nv-flip-sys\extern\cpp\CPP\tensor.h(79): warning C4201: extension non standard utilis�e�: struct/union sans nom
[nv-flip-sys 0.1.1] src/bindings.cpp(21): error C2440: 'initialisation'�: impossible de convertir de 'initializer list' en 'FlipImageColor3'
[nv-flip-sys 0.1.1] src/bindings.cpp(21): note: Initialisation d'agr�gat non valide
[nv-flip-sys 0.1.1] src/bindings.cpp(24): error C3536: 'image'�: ne peut pas �tre utilis� avant d'avoir �t� initialis�
[nv-flip-sys 0.1.1] src/bindings.cpp(32): error C2440: 'return'�: impossible de convertir de 'int' en 'FlipImageColor3 *'
[nv-flip-sys 0.1.1] src/bindings.cpp(32): note: La conversion d'un type int�gral en type pointeur n�cessite reinterpret_cast, un cast de style C ou un cast de style fonction
[nv-flip-sys 0.1.1] src/bindings.cpp(34): error C2440: 'initialisation'�: impossible de convertir de 'initializer list' en 'FlipImageColor3'
[nv-flip-sys 0.1.1] src/bindings.cpp(34): note: Initialisation d'agr�gat non valide
[nv-flip-sys 0.1.1] src/bindings.cpp(39): error C2440: 'initialisation'�: impossible de convertir de 'initializer list' en 'FlipImageColor3'
[nv-flip-sys 0.1.1] src/bindings.cpp(39): note: Initialisation d'agr�gat non valide
[nv-flip-sys 0.1.1] src/bindings.cpp(45): warning C4018: '<'�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] src/bindings.cpp(46): warning C4018: '<'�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] src/bindings.cpp(61): error C2440: 'initialisation'�: impossible de convertir de 'initializer list' en 'FlipImageColor3'
[nv-flip-sys 0.1.1] src/bindings.cpp(61): note: Initialisation d'agr�gat non valide
[nv-flip-sys 0.1.1] src/bindings.cpp(70): error C2440: 'initialisation'�: impossible de convertir de 'initializer list' en 'FlipImageFloat'
[nv-flip-sys 0.1.1] src/bindings.cpp(70): note: Initialisation d'agr�gat non valide
[nv-flip-sys 0.1.1] src/bindings.cpp(73): error C3536: 'image'�: ne peut pas �tre utilis� avant d'avoir �t� initialis�
[nv-flip-sys 0.1.1] src/bindings.cpp(77): error C2440: 'return'�: impossible de convertir de 'int' en 'FlipImageFloat *'
[nv-flip-sys 0.1.1] src/bindings.cpp(77): note: La conversion d'un type int�gral en type pointeur n�cessite reinterpret_cast, un cast de style C ou un cast de style fonction
[nv-flip-sys 0.1.1] src/bindings.cpp(79): error C2440: 'initialisation'�: impossible de convertir de 'initializer list' en 'FlipImageFloat'
[nv-flip-sys 0.1.1] src/bindings.cpp(79): note: Initialisation d'agr�gat non valide
[nv-flip-sys 0.1.1] src/bindings.cpp(84): error C2440: 'initialisation'�: impossible de convertir de 'initializer list' en 'FlipImageFloat'
[nv-flip-sys 0.1.1] src/bindings.cpp(84): note: Initialisation d'agr�gat non valide
[nv-flip-sys 0.1.1] src/bindings.cpp(88): warning C4018: '<'�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] src/bindings.cpp(89): warning C4018: '<'�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] src/bindings.cpp(114): warning C4244: 'return'�: conversion de 'T' en 'size_t', perte possible de donn�es
[nv-flip-sys 0.1.1]         with
[nv-flip-sys 0.1.1]         [
[nv-flip-sys 0.1.1]             T=float
[nv-flip-sys 0.1.1]         ]
[nv-flip-sys 0.1.1] src/bindings.cpp(147): warning C4018: '<'�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] src/bindings.cpp(148): warning C4018: '<'�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] src/bindings.cpp(184): warning C4018: '<'�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] src/bindings.cpp(185): warning C4018: '<'�: incompatibilit� signed/unsigned
[nv-flip-sys 0.1.1] exit code: 2

Stargateur · 2023-09-21T07:53:23Z

It's look like MSVC 2019 16.11.30 is enough to compile nv-flip-sys

cwfitzgerald · 2023-09-21T14:00:59Z

Cool, thank you!

cwfitzgerald · 2023-09-21T22:49:24Z

(This still needs a proper error in the build script)

cwfitzgerald requested changes Sep 21, 2023

View reviewed changes

Add windows requierement

36be793

look like MCVC 2019 is not enough for this project.

Stargateur force-pushed the patch-1 branch from 8e71e68 to 36be793 Compare September 21, 2023 06:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add windows requierement #3

Add windows requierement #3

Stargateur commented Sep 20, 2023

cwfitzgerald left a comment

cwfitzgerald Sep 21, 2023

Stargateur commented Sep 21, 2023 •

edited

Loading

Stargateur commented Sep 21, 2023 •

edited

Loading

Stargateur commented Sep 21, 2023

cwfitzgerald commented Sep 21, 2023

cwfitzgerald commented Sep 21, 2023

Add windows requierement #3

Are you sure you want to change the base?

Add windows requierement #3

Conversation

Stargateur commented Sep 20, 2023

cwfitzgerald left a comment

Choose a reason for hiding this comment

cwfitzgerald Sep 21, 2023

Choose a reason for hiding this comment

Stargateur commented Sep 21, 2023 • edited Loading

Stargateur commented Sep 21, 2023 • edited Loading

Stargateur commented Sep 21, 2023

cwfitzgerald commented Sep 21, 2023

cwfitzgerald commented Sep 21, 2023

Stargateur commented Sep 21, 2023 •

edited

Loading

Stargateur commented Sep 21, 2023 •

edited

Loading