Skip to content

Commit

Permalink
Rollback setup-dotnet action (#940)
Browse files Browse the repository at this point in the history
<!--
For the checkboxes below you must check each one to indicate that you
either did the relevant task, or considered it and decided there was
nothing that needed doing
-->

- [x] Did you write/update appropriate tests
- [x] Release notes updated (if appropriate)
- [x] Appropriate logging output
- [ ] Issue linked
- [x] Docs updated (or issue created)
- [x] New package licenses are added to `ThirdPartyNotices.txt` (if
applicable)

When we upgraded the setup-dotnet action from v1 to v3 yesterday it
caused our builds to get significantly longer (3.5min -> 8.5 min for one
job).

I narrowed it down to something specifically in v3.0.0 of that action. I
will open an issue for the team that owns that action to hopefully help
us shed some more light on what's going on, in the meantime this PR
rolls us back to v2.

<!--
For docs we should review the docs at:

https://docs.github.com/en/early-access/github/migrating-with-github-enterprise-importer
and the README.md in this repo

If a doc update is required based on the changes in this PR, it is
sufficient to create an issue and link to it here. The doc update can be
made later/separately.

The process to update the docs can be found here:
https://github.com/github/docs-early-access#opening-prs

The markdown files are here: 

https://github.com/github/docs-early-access/tree/main/content/github/migrating-with-github-enterprise-importer
-->
  • Loading branch information
dylan-smith authored Apr 4, 2023
1 parent 4db924c commit 5d2a582
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
config-file: ./.github/codeql/codeql-config.yml

- name: Setup .NET
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v2
with:
dotnet-version: 6.0.x

Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:
- uses: actions/checkout@v3

- name: Setup .NET
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v2
with:
dotnet-version: 6.0.x

Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
- uses: actions/checkout@v3

- name: Setup .NET
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v2
with:
dotnet-version: 6.0.x

Expand Down Expand Up @@ -305,7 +305,7 @@ jobs:
}
- name: Setup .NET
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v2
with:
dotnet-version: 6.0.x

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v3

- name: Setup .NET
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v2
with:
dotnet-version: 6.0.x

Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
echo "PR_SHA=$(echo $prsha)" >> $GITHUB_ENV
- name: Setup .NET
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v2
with:
dotnet-version: 6.0.x

Expand Down

0 comments on commit 5d2a582

Please sign in to comment.