Fix the speed of the slow builtin function unit tests in TIv2. #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_756087705
branch
from
debaa02 to
23fda16
Compare
copybara-service
bot
force-pushed
the
test_756087705
branch
from
23fda16 to
e624d74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the speed of the slow builtin function unit tests in TIv2.
Some of the tests exercise a flaw in unification caching where an InferImplicitParametrics call may repeatedly resolve the same heavy type variable within the scope of one resolution call that has a filter. The general caching logic will refuse to capture the result that was influenced by the filter.
This change makes it so that such globally useless results can be retained within the scope of one overarching resolution request, thereby getting the builtin test suite from ~23 sec to ~3 sec.