Avoid repeated work for identical parametric contexts in TIv2. #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Generic utilities may be invoked a large number of times in a target, with parametrics that amount to the same values. In such cases there is no point in having separate caching contexts or repeatedly analyzing the callee function, so this change avoids both of those things. This change also eliminates some unnecessary cache invalidation scenarios. This cuts 80% of the std.x typechecking time. PiperOrigin-RevId: 756797095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid repeated work for identical parametric contexts in TIv2.
Generic utilities may be invoked a large number of times in a target, with parametrics that amount to the same values. In such cases there is no point in having separate caching contexts or repeatedly analyzing the callee function, so this change avoids both of those things. This change also eliminates some unnecessary cache invalidation scenarios.
This cuts 80% of the std.x typechecking time.