chore: reuse fetch method #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mentoss canceled.
|
|
This is a good idea! Can you take a look at the merge conflict? |
By creating the fetch function in the constructor, we allocate a new function every time the mocker is instantiated. We can avoid this by using a field (to bind `this`) which itself delegates to a method on the prototype.
|
i sorted the conflicts, but running the formatter showed we missed some in if you want me to split those into their own PR, let me know |
nzakas
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating the fetch function in the constructor, we allocate a new function every time the mocker is instantiated.
We can avoid this by using a field (to bind
this) which itself delegates to a method on the prototype.