Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add cargo-deny for build #2330

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hypernovasunnix
Copy link

Enables ztunnel to run checks for CVEs and licenses

@hypernovasunnix hypernovasunnix requested a review from a team as a code owner January 19, 2023 21:57
@istio-policy-bot
Copy link

😊 Welcome @hypernovasunnix! This is either your first contribution to the Istio tools repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jan 19, 2023
@istio-testing
Copy link
Contributor

Hi @hypernovasunnix. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 21, 2023
@howardjohn
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 22, 2023
@istio-testing
Copy link
Contributor

@hypernovasunnix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
containers-test-arm64_tools f4a1e0e link true /test containers-test-arm64
lint_tools f4a1e0e link true /test lint
containers-test_tools f4a1e0e link true /test containers-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bleggett
Copy link
Contributor

bleggett commented Jan 27, 2023

Semi-unrelated question - at some point do we plan to create a separate build-tools-ztunnel output image/stage, much like we have for build-tools-proxy?

As we start adding more rust/cargo deps it might begin to make sense.

@ericvn
Copy link
Contributor

ericvn commented Jan 27, 2023

We did have a quick discussion when rust wast added to the image. It would be good to compare sizes occasionally to see what savings we have both ways.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 1, 2023
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants