-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript rewrite, new options, improved workflows & whatnot #30
base: typescript-rewrite
Are you sure you want to change the base?
Conversation
"ReferenceError: Cannot access 'parseBool' before initialization"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @EndBug, left a couple of comments.
description: The number of lines to generate | ||
default: '5' | ||
required: false | ||
NO_COMMIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the motivation behind introducing this input param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one? NO_COMMIT
or LINES
?
NO_COMMIT
: if someone wants to do some other edit to the README they can do it and then push all the changes in a single commit.LINES
: they can select the number of lines from the workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're checking to see if there is any difference between the content enclosed within the respective comments and the latest data being pulled. Any change made to other sections of the README
doesn't affect this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesgeorge007 That's not the issue: I may want to do some other changes to the README and then commit everything together, instead of having multiple commits.
Also, I was thinking of changing the emoji for issue comments to 💬 because it looks better (at least on Windows). Is that ok? |
Looks better on windows? I didn't get your point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts.
…ity-readme into jamesgeorge007-master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your patience. Please resolve the conflicts.
ref commit 78ed73d
Ok, now there should be no more conflicts |
Just as a sidenote: |
I'm sorry for making you wait; it's just that there is plenty on my plate. I had to land a couple of PR's as the need came in, and yeah, they were small. Thank you so much for putting in the efforts here; I'll take a look as time permits. |
Disclaimer: I know this is a huge PR and it's not ideal to have so many changes in a single one. The only reason it's this way it's because I needed to develop it for my README and I couldn't wait for all the changes to be gradually merged in this repo.
Changelog:
LINES
: you can use different numbers of lines.NO_COMMIT
: the action won't commit the resulting file.NO_DEPENDABOT
: the action will filter out events triggered by merging or closing a PR by Dependabot. The reason for this is that I found my actions to be mainly populated by this kind of events since I merge a lot of these PRs.update.yml
), which also runs prettier.update
workflow is already handling the testing (it doesn't run on a matrix, but I think that's fine: almost nobody will need to run this action on macOS, and the action doesn't have platform-specific code)