-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize by forking Default Branch Only #730
Conversation
…ha-3 Signed-off-by: shinigami-777 <[email protected]>
Signed-off-by: shinigami-777 <[email protected]>
…lugin-modernizer-tool into optimize-forking
The new version github-api-2.0-alpha-3 is released now. I took a try at solving the issue. But the |
Adapt the unit tests maybe? |
Signed-off-by: shinigami-777 <[email protected]>
Signed-off-by: shinigami-777 <[email protected]>
Sorry, I somehow completely overlooked this before. |
@jonesbusy When I clone the main branch fresh, the tests are failing the same as this. |
Why not bump version until updatecli merge the PR? We have a contributor that did it on his PR Don't expect maintainers to give you always the information. |
See #733 |
Thanks. I'm looking into it |
...n-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/github/GHService.java
Outdated
Show resolved
Hide resolved
Hi, I think the method name Then I think we are good to merge Supersedes #710 |
Towards #104
Set the
defaultforkonly
to true withGHRepositoryForkBuilder
to in place offork()
(fork was also deprecated in the recent release) to optimize forking process.Submitter checklist