Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grouping to Command Palette #10252

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

This PR adds grouping to the Command Palette, making it easier to identify what each result is.

image

There are a range of prebuilt groups, UnclassifiedSearchGroup, JobSearchGroup, ComputerSearchGroup, ViewSearchGroup, and UserSearchGroup. Developers can add custom groups too, for example, Design Library could add a group for its components and patterns.

Groups by default don't have a specific ordering, however, the projects group is configured to always appear first, and the unclassified group is configured to always appear last. Results are then ordered by name.

I've also done some minor tidy up to the interface, making the overlay a little less invasive.

Testing done

  • Groups appear as expected

Proposed changelog entries

  • Add grouping to Command Palette

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

janfaracik and others added 30 commits December 10, 2024 21:37
This reverts commit 24837ea.
@janfaracik janfaracik requested a review from a team February 10, 2025 16:53
@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Feb 10, 2025
@daniel-beck
Copy link
Member

Could you open a downstream PR for Folders Plugin using this to demonstrate

Developers can add custom groups too

(Where normal folders are not jobs, but MBPLs might end up jobs?)


Also, per https://www.jenkins.io/doc/book/glossary/#project-1, please call them "Jobs" and not "Projects".

@janfaracik
Copy link
Contributor Author

janfaracik commented Feb 11, 2025

Could you open a downstream PR for Folders Plugin using this to demonstrate

Done, using 'Jobs' as a grouping as an example right now although like you say, they're not jobs. Would 'Item' be a better grouping?

Also, per https://www.jenkins.io/doc/book/glossary/#project-1, please call them "Jobs" and not "Projects".

Done, was going to ask about that. Thanks!


Any thoughts on renaming "Jobs" to just be "Items" so we can include folders too? They're part of the same list when in a view, so I think it'd make sense to group them when searching too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants