-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grouping to Command Palette #10252
base: master
Are you sure you want to change the base?
Add grouping to Command Palette #10252
Conversation
This reverts commit 24837ea.
…jenkins into add-icons-to-command-palette
…jenkins into add-icons-to-command-palette
Could you open a downstream PR for Folders Plugin using this to demonstrate
(Where normal folders are not jobs, but MBPLs might end up jobs?) Also, per https://www.jenkins.io/doc/book/glossary/#project-1, please call them "Jobs" and not "Projects". |
Done, using 'Jobs' as a grouping as an example right now although like you say, they're not jobs. Would 'Item' be a better grouping?
Done, was going to ask about that. Thanks! Any thoughts on renaming "Jobs" to just be "Items" so we can include folders too? They're part of the same list when in a view, so I think it'd make sense to group them when searching too. |
This PR adds grouping to the Command Palette, making it easier to identify what each result is.
There are a range of prebuilt groups,
UnclassifiedSearchGroup
,JobSearchGroup
,ComputerSearchGroup
,ViewSearchGroup
, andUserSearchGroup
. Developers can add custom groups too, for example, Design Library could add a group for its components and patterns.Groups by default don't have a specific ordering, however, the projects group is configured to always appear first, and the unclassified group is configured to always appear last. Results are then ordered by name.
I've also done some minor tidy up to the interface, making the overlay a little less invasive.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist