Tracking a strange test failure.

Signed-off-by: Simone Bordet <[email protected]>
jetty-project · Mar 22, 2021 · 9fa9345 · 9fa9345
1 parent d5c7d14
commit 9fa9345
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/...y-load-generator-client/src/main/java/org/mortbay/jetty/load/generator/LoadGenerator.java b/...y-load-generator-client/src/main/java/org/mortbay/jetty/load/generator/LoadGenerator.java
@@ -205,6 +205,9 @@ public CompletableFuture<Void> begin() {
      */
     @ManagedOperation(value = "Interrupts this LoadGenerator", impact = "ACTION")
     public void interrupt() {
+        if (LOGGER.isDebugEnabled()) {
+            LOGGER.debug("interrupting {}", this);
+        }
         interrupt = true;
     }
 

diff --git a/...ad-generator-client/src/test/java/org/mortbay/jetty/load/generator/LoadGeneratorTest.java b/...ad-generator-client/src/test/java/org/mortbay/jetty/load/generator/LoadGeneratorTest.java
@@ -348,10 +348,14 @@ public void testJMX() throws Exception {
 
         Thread.sleep(1000);
 
-        // need empty array otherwise jdk11 throw NPE
-        mbeanContainer.getMBeanServer().invoke(objectName, "interrupt", null, new String[]{});
+        // Needs empty arrays otherwise Java 11 throws NPE.
+        mbeanContainer.getMBeanServer().invoke(objectName, "interrupt", new Object[0], new String[0]);
 
         cf.handle((r, x) -> {
+            if (x == null)
+                Thread.dumpStack();
+            // Load generation was interrupted.
+            Assert.assertNotNull(x);
             Throwable cause = x.getCause();
             if (cause instanceof InterruptedException) {
                 return null;