implements fail fast when sending request fail #13

Signed-off-by: olivier lamy <[email protected]>
jetty-project · Apr 1, 2017 · b872482 · b872482
1 parent 9816af8
commit b872482
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/...y-load-generator-client/src/main/java/org/mortbay/jetty/load/generator/LoadGenerator.java b/...y-load-generator-client/src/main/java/org/mortbay/jetty/load/generator/LoadGenerator.java
@@ -294,6 +294,7 @@ public void failed(Throwable x) {
                     logger.debug("failed tree for {}", resource);
                 }
                 callback.failed(x);
+                LoadGenerator.this.interrupt();
             }
         }, nodes);
         Sender sender = new Sender(client, warmup, treeCallback);

diff --git a/jetty-load-generator-client/src/test/java/org/mortbay/jetty/load/generator/FailFastTest.java b/jetty-load-generator-client/src/test/java/org/mortbay/jetty/load/generator/FailFastTest.java
@@ -34,16 +34,13 @@
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
-import org.junit.BeforeClass;
 import org.junit.Test;
 
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 import java.io.IOException;
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 
 public class FailFastTest
@@ -152,7 +149,6 @@ protected void service( HttpServletRequest request, HttpServletResponse response
                 {
                     throw new RuntimeException( e.getMessage(), e );
                 }
-
             }
             response.getOutputStream().write( "Jetty rocks!!".getBytes() );
             response.flushBuffer();

diff --git a/.../src/main/java/org/mortbay/jetty/load/generator/starter/AbstractLoadGeneratorStarter.java b/.../src/main/java/org/mortbay/jetty/load/generator/starter/AbstractLoadGeneratorStarter.java
@@ -81,6 +81,11 @@ public void run()
             .warmupIterationsPerThread( starterArgs.getWarmupNumber() ) //
             .scheme( starterArgs.getScheme() ); //
 
+        if (starterArgs.getThreads() > 0)
+        {
+            loadGeneratorBuilder.threads( starterArgs.getThreads() );
+        }
+
         if ( starterArgs.getMaxRequestsQueued() > 0 )
         {
             loadGeneratorBuilder.maxRequestsQueued( starterArgs.getMaxRequestsQueued() );
@@ -91,11 +96,6 @@ public void run()
             loadGeneratorBuilder.executor( getExecutorService() );
         }
 
-        if ( starterArgs.getThreads() > 0 )
-        {
-            loadGeneratorBuilder.threads( starterArgs.getThreads() );
-        }
-
         if ( starterArgs.getRunningTime() > 0 )
         {
             loadGeneratorBuilder.runFor( starterArgs.getRunningTime(), starterArgs.getRunningTimeUnit() );