Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threads must wait to be ready #8

Closed
sbordet opened this issue Feb 20, 2017 · 1 comment
Closed

Threads must wait to be ready #8

sbordet opened this issue Feb 20, 2017 · 1 comment
Assignees
@olamy
Milestone
1.0.0

Comments

@sbordet
Copy link
Member

sbordet commented Feb 20, 2017

Performing work in N threads must ensure that the N threads are really all started and ready to perform the work.

Currently, Runnable tasks are created and submitted to the Executor in a loop, which may cause the first task to run to completion before the second task is even submitted.

The code should use a barrier that waits for all the threads to be ready, and only then release the barrier to make all the threads perform the work.
@olamy olamy self-assigned this Feb 21, 2017
olamy added a commit that referenced this issue Feb 21, 2017
@olamy
build Callable first before invoke fix #8
e94746e 
Signed-off-by: olivier lamy <[email protected]>
@olamy olamy mentioned this issue Feb 21, 2017
Closed
@olamy olamy closed this as completed Mar 28, 2017
@olamy
Copy link
Member

olamy commented Mar 28, 2017

done

@olamy olamy added this to the 1.0.0 milestone Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olamy olamy

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@olamy @sbordet