Threads must wait to be ready #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: olivier lamy <[email protected]>
|
@sbordet please have a look |
sbordet
reviewed
Feb 21, 2017
| @@ -437,6 +440,8 @@ public void run( int transactionNumber ) | |||
| } | |||
| } | |||
|
|
|||
| List<Future<Void>> futures = this.runnersExecutorService.invokeAll( callables ); | |||
There was a problem hiding this comment.
Not good, invokeAll() blocks until all tasks are complete.
sbordet
reviewed
Feb 21, 2017
| @@ -139,25 +144,28 @@ private void handleResource( Resource resource ) | |||
| // it's a group so we can request in parallel but wait all responses before next step | |||
| ExecutorService executorService = Executors.newWorkStealingPool(); | |||
There was a problem hiding this comment.
Not sure why we want to create a new ExecutorService here ? Can't we just use the existing one ?
Signed-off-by: olivier lamy <[email protected]>
Signed-off-by: olivier lamy <[email protected]>
Signed-off-by: olivier lamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #8