Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #82 - Reduce allocation for node and tree events #83

Merged
merged 1 commit into from
May 17, 2021
+14 −8
Merged

Fixes #82 - Reduce allocation for node and tree events #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions ...y-load-generator-client/src/main/java/org/mortbay/jetty/load/generator/LoadGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,10 +530,13 @@ private void invokeCompleteListener(CompleteListener listener) {
}

private void fireResourceNodeEvent(Resource.Info info) {
config.getResourceListeners().stream()
.filter(l -> l instanceof Resource.NodeListener)
.map(l -> (Resource.NodeListener)l)
.forEach(l -> invokeResourceNodeListener(l, info));
// Java streams are too expensive allocation-wise
// to be used for events generated in large numbers.
for (Resource.Listener l : config.getResourceListeners()) {
if (l instanceof Resource.NodeListener) {
invokeResourceNodeListener((Resource.NodeListener)l, info);
}
}
}

private void invokeResourceNodeListener(Resource.NodeListener listener, Resource.Info info) {
Expand All @@ -545,10 +548,13 @@ private void invokeResourceNodeListener(Resource.NodeListener listener, Resource
}

private void fireResourceTreeEvent(Resource.Info info) {
config.getResourceListeners().stream()
.filter(l -> l instanceof Resource.TreeListener)
.map(l -> (Resource.TreeListener)l)
.forEach(l -> invokeResourceTreeListener(l, info));
// Java streams are too expensive allocation-wise
// to be used for events generated in large numbers.
for (Resource.Listener l : config.getResourceListeners()) {
if (l instanceof Resource.TreeListener) {
invokeResourceTreeListener((Resource.TreeListener)l, info);
}
}
}

private void invokeResourceTreeListener(Resource.TreeListener listener, Resource.Info info) {
Expand Down