multi language open tasks #2315
Conversation
|
languages/multi-language/src/main/java/de/jplag/multilang/MultiLanguageParser.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public List<Token> parseFiles(Set<File> files, boolean normalize) throws ParsingException { | ||
| this.printWarning(); | ||
| List<Token> results = new ArrayList<>(); | ||
| for (File file : files) { | ||
| Optional<Language> language = findLanguageForFile(file); |
There was a problem hiding this comment.
We discussed that we can find out at compile time whether the mapping of file extensions to language modules is well-defined. I would argue then that we should set up an actual look up table instead of repeating the same steps for each individual file.
There was a problem hiding this comment.
This is not a specific warning, but a general one that is printed the first time the language module is used. See #2304
There was a problem hiding this comment.
if someone wants to use the content and not only the file extensions: https://github.com/ArDoCo/magika we ported magika to java :)
There was a problem hiding this comment.
We could do that, but I'd recommend doing it in a separate PR and everywhere in JPlag
There was a problem hiding this comment.
Yes, I meant it as general information . I would not implement it in this PR :)
tsaglam
added
enhancement
Fixes the open tasks from #2304