Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cancel check to be shadowRoot compatible #2086

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jun 10, 2022

  1. Update cancel check to be shadowRoot compatible

    This proposal is made to correctly check if the event should be canceled if the first element in the composedPath (or the event.target) matches with the options.cancel selector
    malarahfelipe authored Jun 10, 2022
    Configuration menu
    Copy the full SHA
    3a1b590 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Mouse: Update elIsCancel to use composedPath instead of event.target

    When using web-components with shadowRoot, the mouseDown event is triggered with the event.target pointing to the entire web component, not inner nodes that were clicked, thus to cancel the mouseDown based on inner-elements we have to use composedPath instead of event.target
    malarahfelipe committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    b88cfde View commit details
    Browse the repository at this point in the history