Skip to content

Commit

Permalink
Minor fix for hugepages: remove locked (#708)
Browse files Browse the repository at this point in the history
Co-authored-by: Vincent S. Cojot <[email protected]>
  • Loading branch information
2 people authored and karmab committed Aug 13, 2024
1 parent ec8c845 commit 2c555f6
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions kvirt/providers/kvm/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1262,9 +1262,16 @@ def create(self, name, virttype=None, profile='kvirt', flavor=None, plan='kvirt'
hugepagesxml = ""
hugepages = overrides.get('hugepages', False)
hugepages_1gb = overrides.get('hugepages_1gb', False)
if hugepages or hugepages_1gb:
sizexml = "<hugepages><page size='1048576' unit='KiB'/></hugepages>" if hugepages_1gb else '<hugepages/>'
hugepagesxml = f"<memoryBacking>{sizexml}<locked/></memoryBacking>"
hugepages_2mb = overrides.get('hugepages_1gb', False)
need_hugepages = hugepages or hugepages_1gb or hugepages_2mb
if need_hugepages:
if hugepages_1gb:
sizexml = "<hugepages><page size='1048576' unit='KiB'/></hugepages>"
elif hugepages_2mb:
sizexml = "<hugepages><page size='2' unit='MiB'/></hugepages>"
else:
sizexml = '<hugepages/>'
hugepagesxml = f"<memoryBacking>{sizexml}</memoryBacking>"
machine = f"machine='{machine}'"
emulatorxml = f"<emulator>{emulator}</emulator>"
uuidxml = ""
Expand Down

0 comments on commit 2c555f6

Please sign in to comment.