OpenShift: Web server on different IP #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use a self signed `bmc_url` the code fails with a bad error:
```
File "/usr/lib/python3.13/site-packages/kvirt/kfish/__init__.py", line 54, in get_info
error(f"Hit issue {e.msg} when accessing url {chassis_url}")
^^^^^
AttributeError: 'URLError' object has no attribute 'msg'
```
The actual error is
```
URLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1020)'))
```
This patch adds a generic mechanism to print a text version of the error
when thee `msg` attribute is not present in the exception.
When serving ISO images for baremetal machines on the OpenShift cluster deployment we were assuming that these were always served on the `default` network interface, and that's the IP address that was configured on the BMC of the baremetal server. This only works if we are running kcli on the same network as the servers, but that's not the case when we access them through a VPN. In this patch we add a new configuration option named `baremetal_web_nic` that allows us to specify the network interface we want to use to serve the ISO. The default value will be `default`, to maintain backward compatibility, but for example we could set it to `tun0` when using the VPN to access the machines to be provisioned.
karmab
force-pushed
the
main
branch
3 times, most recently
from
7b3f421 to
b87ce13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving ISO images for baremetal machines on the OpenShift cluster
deployment we were assuming that these were always served on the
defaultnetwork interface, and that's the IP address that wasconfigured on the BMC of the baremetal server.
This only works if we are running kcli on the same network as the
servers, but that's not the case when we access them through a VPN.
In this patch we add a new configuration option named
baremetal_web_nicthat allows us to specify the network interface wewant to use to serve the ISO.
The default value will be
default, to maintain backward compatibility,but for example we could set it to
tun0when using the VPN to accessthe machines to be provisioned.