Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorityClassName in PropagationPolicy & ClusterPropagationPolicy #5962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented Dec 19, 2024

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Add SchedulePriority to PropagationPolicy & ClusterPropagationPolicy to support flexible priority class resolution strategies:

  • KubePriorityClass: Use Kubernetes native PriorityClass
  • PodPriorityClass: Use priority from workload's PodTemplate
  • FederatedPriorityClass: Reserved for future Karmada-specific priority classes

This enhancement allows users to:

  1. Specify which priority class source to use
  2. Control resource scheduling priority
  3. Maintain consistent priority behavior with Kubernetes

Which issue(s) this PR fixes:
Part of #5961

Special notes for your reviewer:

  • Default source is KubePriorityClass
  • Falls back to global default if unspecified
  • FederatedPriorityClass is reserved for future implementation
  • All new fields are optional to maintain backward compatibility

Does this PR introduce a user-facing change?:

Add SchedulePriority field to PropagationPolicy and ClusterPropagationPolicy:
- Supports multiple priority class sources (Kubernetes, PodTemplate, Federated[future])
- Configurable priority class resolution strategy
- Maintains compatibility with Kubernetes priority behavior
- Optional fields preserve backward compatibility

@karmada-bot karmada-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 19, 2024
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.33%. Comparing base (5bfdf61) to head (25e0f40).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5962   +/-   ##
=======================================
  Coverage   48.33%   48.33%           
=======================================
  Files         666      666           
  Lines       54858    54858           
=======================================
+ Hits        26516    26518    +2     
+ Misses      26617    26616    -1     
+ Partials     1725     1724    -1     
Flag Coverage Δ
unittests 48.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants