add work mutating in ctrlutil.CreateOrUpdateWork() #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/feature
karmada-bot
requested review from
chaunceyjiang,
whitewindmills and
XiShanYongYe-Chang
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/L
Signed-off-by: zach593 <[email protected]>
zach593
force-pushed
the
work-mutating
branch
from
4fb641c to
4976704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
It could remove unnecessary update operations in
ctrlutil.CreateOrUpdateWork(), by mutating theWorkin advance, and letDeepEqual()return true. when karmada-controller-manager restart, this may help reduce the time it takes to clear the work queue.Should be part of #6031, if it's not true please correct me.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Tests will remain failing until #6028 is merged and this PR is rebased on it.
Does this PR introduce a user-facing change?: