-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ci) test with lowest dependency required version #170
base: master
Are you sure you want to change the base?
Conversation
This makes sense, thanks @Sysix. But the tests are failing. I think it's because of the PHPUnit dependency, but not quite sure. |
PHP 8 Support is only available for phpunit 9.3: Also testbench support laravel 8 at version 6.*: EDIT: when its still not working, we need to drop the phpunit 9 support. Should not be that much of a problem 🤞 |
PHPUnit 10 supports only PHP8.1. PHPUnit 9.5 removed the deprecation warning Then another wierd Bug was happening with testbench < 6.24:
When requiring testbench 6.24 this bug is fixed. Don't know why :/ EDIT: I looked which version is tested for laravel. The tests require laravel 8.75.0 so we should also reflect that. |
the CI overwrote our requirements. Updated the github workflow too :) |
Still erroring. I'm not opposed on dropping support for outdated Laravel/PHP versions, if that helps |
I forgot one line to update. |
e1e576a
to
d858f29
Compare
Hey @Sysix, we updated this based on the latest master, but it appears to be broken as the testbench versions are now not being passed through to that installation command. It would be great if you had any ideas about what is wrong! |
Co-authored-by: Alexander S. <[email protected]>
At the moment we install all our dependencies with the highest minor & patch number.
Because this project support all major versions from the beginning (
X.0
) we should also test these specific versions too.There is a composer command which will help us:
--prefer-lowest
From the composer docs it suggest to also include
--prefer-stable