Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display which path failed to decode #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jeff-Tian
Copy link

Why

Hello, when I started a koa server and sent a template HTML to the client, the server showed an error "failed to decode BadRequestError: failed to decode" which is not clear enough to let me spot the issue instantly.

After more investigation, I found it's caused by the URL specified in the HTML template being malformed to the koa server.

So I think it might help to let the developer know the root cause immediately by enhancing the error message to display the path that failed to decode.

Screenshots

image

image

Thanks for your time to review!

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@Jeff-Tian
Copy link
Author

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant