Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cloudflare): add scenarios on submitChanges #5054

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AndrewCharlesHay
Copy link
Contributor

In the process of debugging #5035

Description

Fixes #ISSUE

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @AndrewCharlesHay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2025
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Hi @AndrewCharlesHay you could share in the thread a bit more about the setup. I have quite few cloudflare setups, not came across the problem myself, but if I could understand the setup, my be able to reproduce as well.

cc: @mloiseleur

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivankatliarchuk
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mloiseleur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2025
@mloiseleur
Copy link
Contributor

/retitle test(cloudflare): add scenarios on submitChanges

@k8s-ci-robot k8s-ci-robot changed the title test(cloudflare_test): add test for submit changes test(cloudflare): add scenarios on submitChanges Feb 2, 2025
@AndrewCharlesHay
Copy link
Contributor Author

/lgtm

Hi @AndrewCharlesHay you could share in the thread a bit more about the setup. I have quite few cloudflare setups, not came across the problem myself, but if I could understand the setup, my be able to reproduce as well.

cc: @mloiseleur

@ivankatliarchuk I haven't encountered the error yet. We are still on version 14. I'm trying to fix the issue before we upgrade. We don't have a test account so I've hesitated to upgrade before we know it works.

@mloiseleur
Copy link
Contributor

@AndrewCharlesHay Have you tried on an APEX record ?

@AndrewCharlesHay
Copy link
Contributor Author

@AndrewCharlesHay Have you tried on an APEX record ?

@mloiseleur I have not. I will try that tomorrow. To be honest I've never heard of an APEX record so I learned something new today

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2025
@AndrewCharlesHay
Copy link
Contributor Author

@mloiseleur Sorry for the wait. The APEX record test should be there now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants