-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cloudflare): add scenarios on submitChanges #5054
base: master
Are you sure you want to change the base?
test(cloudflare): add scenarios on submitChanges #5054
Conversation
Hi @AndrewCharlesHay. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hi @AndrewCharlesHay you could share in the thread a bit more about the setup. I have quite few cloudflare setups, not came across the problem myself, but if I could understand the setup, my be able to reproduce as well.
cc: @mloiseleur
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retitle test(cloudflare): add scenarios on submitChanges |
@ivankatliarchuk I haven't encountered the error yet. We are still on version 14. I'm trying to fix the issue before we upgrade. We don't have a test account so I've hesitated to upgrade before we know it works. |
@AndrewCharlesHay Have you tried on an APEX record ? |
@mloiseleur I have not. I will try that tomorrow. To be honest I've never heard of an APEX record so I learned something new today |
New changes are detected. LGTM label has been removed. |
@mloiseleur Sorry for the wait. The APEX record test should be there now |
In the process of debugging #5035
Description
Fixes #ISSUE
Checklist