Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Signoff Checklist for KEP-1495 Volume Populators #5023

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Jan 7, 2025

  • One-line PR description:
    Update Release Signoff Checklist from Template for KEP-1495 Volume Populators

/assign @msau42

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2025
@xing-yang
Copy link
Contributor

Please take a look at the latest template: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template. I found the following sections are missing:

Monitoring Requirements:
How can someone using this feature know that it is working for their instance?

Scalability:
Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

Drawbacks

@xing-yang
Copy link
Contributor

In the Test Plan section, we should have a section for unit tests, integration tests, and e2e tests, each with a link to the test coverage and testgrid if available.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@sunnylovestiramisu sunnylovestiramisu force-pushed the updateKEP branch 2 times, most recently from 9a66f87 to ad7dbd5 Compare January 16, 2025 16:15
@sunnylovestiramisu
Copy link
Contributor Author

/assign @deads2k

Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you answer the following questions from the new KEP template?

Monitoring Requirements:
How can someone using this feature know that it is working for their instance?

Scalability:
Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

@deads2k
Copy link
Contributor

deads2k commented Jan 20, 2025

PRR lgtm, but the sig owns the promotion decision

/approve

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sunnylovestiramisu, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9f7ee23 into kubernetes:master Jan 22, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants