-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Release Signoff Checklist for KEP-1495 Volume Populators #5023
Conversation
Please take a look at the latest template: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template. I found the following sections are missing: Monitoring Requirements: Scalability: Drawbacks |
In the Test Plan section, we should have a section for unit tests, integration tests, and e2e tests, each with a link to the test coverage and testgrid if available. |
f5e8f49
to
2d71083
Compare
9a66f87
to
ad7dbd5
Compare
/assign @deads2k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you answer the following questions from the new KEP template?
Monitoring Requirements:
How can someone using this feature know that it is working for their instance?
Scalability:
Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
ad7dbd5
to
c6b47b3
Compare
c6b47b3
to
f4f7df2
Compare
PRR lgtm, but the sig owns the promotion decision /approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sunnylovestiramisu, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update Release Signoff Checklist from Template for KEP-1495 Volume Populators
/assign @msau42