Make QueryResult::toString const #5013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5013 +/- ##
==========================================
+ Coverage 87.88% 87.91% +0.03%
==========================================
Files 1422 1427 +5
Lines 64377 64557 +180
Branches 7560 7576 +16
==========================================
+ Hits 56576 56755 +179
- Misses 7772 7773 +1
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benjaminwinger
force-pushed
the
const-to-string
branch
2 times, most recently
from
f7e918f to
a1c7ffa
Compare
Benchmark ResultMaster commit hash:
|
andyfengHKU
approved these changes
Mar 8, 2025
benjaminwinger
force-pushed
the
const-to-string
branch
3 times, most recently
from
9c33b9a to
b27c401
Compare
benjaminwinger
force-pushed
the
const-to-string
branch
from
b27c401 to
1193120
Compare
Benchmark ResultMaster commit hash:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having toString mutate the query result means that in rust we can't use the Display trait (safely anyway). I think it's also somewhat unintuitive for it to mutate itself in this case.
I'd actually looked at this a while ago but had been attempting to separate the iterator from the QueryResult entirely (e.g. have a
QueryResult::itermethod that produces an iterator which has getNext/hasNext functions instead of having that be directly on the QueryResult, but that affected a lot of stuff so I never finished it.Instead, I've made it so that QueryResult::toString uses its own FlatTupleIterator/FlatTuple and avoids mutating the one from the QueryResult.
There will be a subtle difference in behaviour, as you can no longer start consuming the results and then use
toStringto print the remaining results, but hopefully that's not behaviour anyone was relying on.