Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GDS table function #5048

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Make GDS table function #5048

merged 1 commit into from
Mar 14, 2025

Conversation

andyfengHKU
Copy link
Contributor

Description

Please include a summary of the changes and the related issue (if applicable). Please also include
relevant motivation and context.

Fixes # (issue)

Contributor agreement

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: d45b10096fe4088ded5726b5d5607f8f29af891a
Branch commit hash: ee8eab93e38bdeb001541dda59b489ad7d84c894

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 727.38 747.87 -20.49 (-2.74%)
aggregation q28 6568.20 6618.13 -49.93 (-0.75%)
filter q14 125.62 145.28 -19.66 (-13.53%)
filter q15 127.05 145.28 -18.24 (-12.55%)
filter q16 338.78 368.99 -30.21 (-8.19%)
filter q17 446.58 463.15 -16.57 (-3.58%)
filter q18 2030.31 1989.32 40.99 (2.06%)
filter zonemap-node 88.87 105.27 -16.41 (-15.58%)
filter zonemap-node-lhs-cast 88.55 104.70 -16.16 (-15.43%)
filter zonemap-node-null 88.87 104.52 -15.65 (-14.97%)
filter zonemap-rel 5786.54 5701.98 84.55 (1.48%)
fixed_size_expr_evaluator q07 680.82 708.50 -27.67 (-3.91%)
fixed_size_expr_evaluator q08 968.16 993.72 -25.56 (-2.57%)
fixed_size_expr_evaluator q09 963.37 997.45 -34.08 (-3.42%)
fixed_size_expr_evaluator q10 254.53 283.05 -28.52 (-10.08%)
fixed_size_expr_evaluator q11 254.45 283.75 -29.30 (-10.33%)
fixed_size_expr_evaluator q12 234.01 262.03 -28.01 (-10.69%)
fixed_size_expr_evaluator q13 1558.14 1583.36 -25.22 (-1.59%)
fixed_size_seq_scan q23 114.28 132.67 -18.39 (-13.86%)
join q29 761.88 769.03 -7.16 (-0.93%)
join q30 1577.02 1678.25 -101.23 (-6.03%)
join q31 5.21 6.79 -1.58 (-23.28%)
join SelectiveTwoHopJoin 53.18 43.39 9.78 (22.54%)
ldbc_snb_ic q35 10.16 8.76 1.40 (16.01%)
ldbc_snb_ic q36 99.19 99.65 -0.45 (-0.46%)
ldbc_snb_is q32 6.52 6.70 -0.19 (-2.76%)
ldbc_snb_is q33 13.34 13.91 -0.56 (-4.04%)
ldbc_snb_is q34 1.20 1.21 -0.01 (-1.07%)
multi-rel multi-rel-large-scan 1671.73 1754.12 -82.39 (-4.70%)
multi-rel multi-rel-lookup 12.03 10.58 1.45 (13.76%)
multi-rel multi-rel-small-scan 209.27 206.64 2.63 (1.27%)
order_by q25 131.37 148.19 -16.82 (-11.35%)
order_by q26 447.85 472.21 -24.36 (-5.16%)
order_by q27 1382.45 1416.71 -34.26 (-2.42%)
recursive_join recursive-join-bidirection 271.77 289.72 -17.95 (-6.20%)
recursive_join recursive-join-dense 7210.08 5068.26 2141.82 (42.26%)
recursive_join recursive-join-path 23400.68 22563.66 837.03 (3.71%)
recursive_join recursive-join-sparse 641.22 626.19 15.02 (2.40%)
recursive_join recursive-join-trail 7086.75 5567.59 1519.16 (27.29%)
scan_after_filter q01 172.28 187.83 -15.55 (-8.28%)
scan_after_filter q02 157.53 175.48 -17.95 (-10.23%)
shortest_path_ldbc100 q37 89.65 89.56 0.09 (0.10%)
shortest_path_ldbc100 q38 318.01 322.29 -4.27 (-1.33%)
shortest_path_ldbc100 q39 64.80 59.74 5.06 (8.47%)
shortest_path_ldbc100 q40 385.59 409.23 -23.64 (-5.78%)
var_size_expr_evaluator q03 2084.56 2109.08 -24.53 (-1.16%)
var_size_expr_evaluator q04 2313.11 2310.33 2.78 (0.12%)
var_size_expr_evaluator q05 2680.22 2686.91 -6.69 (-0.25%)
var_size_expr_evaluator q06 1340.47 1371.76 -31.28 (-2.28%)
var_size_seq_scan q19 1438.17 1445.00 -6.83 (-0.47%)
var_size_seq_scan q20 2736.21 2700.86 35.35 (1.31%)
var_size_seq_scan q21 2309.27 2258.10 51.17 (2.27%)
var_size_seq_scan q22 127.52 128.70 -1.18 (-0.92%)

@ray6080 ray6080 self-requested a review March 13, 2025 13:06
acquamarin
acquamarin approved these changes Mar 13, 2025
View reviewed changes
@andyfengHKU andyfengHKU force-pushed the make-gds-table-func branch from 7409225 to 53311ee Compare March 13, 2025 16:08
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: d45b10096fe4088ded5726b5d5607f8f29af891a
Branch commit hash: c77a689750b81fb66f06735e0d0ee635256c6088

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 724.75 747.87 -23.12 (-3.09%)
aggregation q28 6565.92 6618.13 -52.21 (-0.79%)
filter q14 125.29 145.28 -19.99 (-13.76%)
filter q15 126.55 145.28 -18.74 (-12.90%)
filter q16 340.17 368.99 -28.82 (-7.81%)
filter q17 448.61 463.15 -14.54 (-3.14%)
filter q18 1998.03 1989.32 8.71 (0.44%)
filter zonemap-node 88.73 105.27 -16.54 (-15.72%)
filter zonemap-node-lhs-cast 89.45 104.70 -15.25 (-14.57%)
filter zonemap-node-null 89.30 104.52 -15.22 (-14.56%)
filter zonemap-rel 5607.05 5701.98 -94.93 (-1.66%)
fixed_size_expr_evaluator q07 678.31 708.50 -30.19 (-4.26%)
fixed_size_expr_evaluator q08 959.00 993.72 -34.72 (-3.49%)
fixed_size_expr_evaluator q09 956.98 997.45 -40.46 (-4.06%)
fixed_size_expr_evaluator q10 256.74 283.05 -26.32 (-9.30%)
fixed_size_expr_evaluator q11 257.52 283.75 -26.24 (-9.25%)
fixed_size_expr_evaluator q12 233.65 262.03 -28.37 (-10.83%)
fixed_size_expr_evaluator q13 1566.79 1583.36 -16.57 (-1.05%)
fixed_size_seq_scan q23 108.97 132.67 -23.70 (-17.87%)
join q29 714.35 769.03 -54.69 (-7.11%)
join q30 1643.58 1678.25 -34.67 (-2.07%)
join q31 6.53 6.79 -0.26 (-3.82%)
join SelectiveTwoHopJoin 47.85 43.39 4.46 (10.28%)
ldbc_snb_ic q35 8.91 8.76 0.15 (1.75%)
ldbc_snb_ic q36 84.57 99.65 -15.08 (-15.13%)
ldbc_snb_is q32 6.41 6.70 -0.30 (-4.43%)
ldbc_snb_is q33 12.34 13.91 -1.57 (-11.29%)
ldbc_snb_is q34 1.67 1.21 0.45 (37.40%)
multi-rel multi-rel-large-scan 1762.81 1754.12 8.69 (0.50%)
multi-rel multi-rel-lookup 10.15 10.58 -0.42 (-3.99%)
multi-rel multi-rel-small-scan 205.47 206.64 -1.17 (-0.57%)
order_by q25 127.80 148.19 -20.39 (-13.76%)
order_by q26 449.03 472.21 -23.18 (-4.91%)
order_by q27 1366.58 1416.71 -50.12 (-3.54%)
recursive_join recursive-join-bidirection 266.06 289.72 -23.66 (-8.17%)
recursive_join recursive-join-dense 7149.79 5068.26 2081.53 (41.07%)
recursive_join recursive-join-path 23353.39 22563.66 789.73 (3.50%)
recursive_join recursive-join-sparse 628.84 626.19 2.64 (0.42%)
recursive_join recursive-join-trail 7058.72 5567.59 1491.13 (26.78%)
scan_after_filter q01 169.13 187.83 -18.70 (-9.95%)
scan_after_filter q02 156.49 175.48 -18.99 (-10.82%)
shortest_path_ldbc100 q37 83.94 89.56 -5.62 (-6.27%)
shortest_path_ldbc100 q38 217.64 322.29 -104.65 (-32.47%)
shortest_path_ldbc100 q39 56.75 59.74 -2.98 (-5.00%)
shortest_path_ldbc100 q40 247.26 409.23 -161.97 (-39.58%)
var_size_expr_evaluator q03 2079.68 2109.08 -29.40 (-1.39%)
var_size_expr_evaluator q04 2306.22 2310.33 -4.11 (-0.18%)
var_size_expr_evaluator q05 2665.08 2686.91 -21.83 (-0.81%)
var_size_expr_evaluator q06 1329.51 1371.76 -42.25 (-3.08%)
var_size_seq_scan q19 1420.47 1445.00 -24.53 (-1.70%)
var_size_seq_scan q20 2606.35 2700.86 -94.51 (-3.50%)
var_size_seq_scan q21 2272.59 2258.10 14.49 (0.64%)
var_size_seq_scan q22 123.72 128.70 -4.98 (-3.87%)

@andyfengHKU andyfengHKU force-pushed the make-gds-table-func branch from cf37339 to 505e005 Compare March 14, 2025 05:25
@andyfengHKU andyfengHKU force-pushed the make-gds-table-func branch from 505e005 to 5919ee5 Compare March 14, 2025 05:43
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 640e07be731e1da4cfb0befd8d7e5694f5792e9b
Branch commit hash: 117db343d824a2934d6d29b57b7d1330e7de0cb3

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 792.92 724.88 68.04 (9.39%)
aggregation q28 5843.54 6559.72 -716.19 (-10.92%)
filter q14 134.39 124.66 9.73 (7.81%)
filter q15 133.22 121.88 11.35 (9.31%)
filter q16 350.55 342.90 7.65 (2.23%)
filter q17 433.94 446.25 -12.31 (-2.76%)
filter q18 1946.47 2003.87 -57.40 (-2.86%)
filter zonemap-node 90.34 89.20 1.15 (1.29%)
filter zonemap-node-lhs-cast 86.52 89.43 -2.91 (-3.25%)
filter zonemap-node-null 87.06 88.50 -1.44 (-1.63%)
filter zonemap-rel 5687.57 5719.25 -31.68 (-0.55%)
fixed_size_expr_evaluator q07 731.65 680.03 51.62 (7.59%)
fixed_size_expr_evaluator q08 981.54 961.84 19.70 (2.05%)
fixed_size_expr_evaluator q09 982.40 971.36 11.04 (1.14%)
fixed_size_expr_evaluator q10 261.00 254.43 6.57 (2.58%)
fixed_size_expr_evaluator q11 260.23 254.41 5.82 (2.29%)
fixed_size_expr_evaluator q12 233.18 233.60 -0.42 (-0.18%)
fixed_size_expr_evaluator q13 1582.27 1605.76 -23.50 (-1.46%)
fixed_size_seq_scan q23 119.98 107.66 12.32 (11.45%)
join q29 784.08 759.98 24.10 (3.17%)
join q30 1633.05 1625.47 7.58 (0.47%)
join q31 7.30 5.11 2.19 (42.86%)
join SelectiveTwoHopJoin 48.75 40.05 8.70 (21.73%)
ldbc_snb_ic q35 8.87 7.22 1.65 (22.92%)
ldbc_snb_ic q36 85.99 100.79 -14.80 (-14.68%)
ldbc_snb_is q32 3.99 4.57 -0.57 (-12.54%)
ldbc_snb_is q33 11.71 12.99 -1.29 (-9.90%)
ldbc_snb_is q34 1.16 1.23 -0.07 (-5.87%)
multi-rel multi-rel-large-scan 1768.97 1673.69 95.28 (5.69%)
multi-rel multi-rel-lookup 10.62 10.41 0.22 (2.08%)
multi-rel multi-rel-small-scan 197.14 205.99 -8.85 (-4.30%)
order_by q25 140.60 132.98 7.61 (5.73%)
order_by q26 475.42 449.72 25.71 (5.72%)
order_by q27 1453.80 1387.27 66.52 (4.80%)
recursive_join recursive-join-bidirection 296.14 309.20 -13.06 (-4.22%)
recursive_join recursive-join-dense 7212.03 5651.36 1560.67 (27.62%)
recursive_join recursive-join-path 23373.28 23002.52 370.76 (1.61%)
recursive_join recursive-join-sparse 626.95 632.41 -5.46 (-0.86%)
recursive_join recursive-join-trail 7067.64 6057.96 1009.69 (16.67%)
scan_after_filter q01 180.59 169.12 11.46 (6.78%)
scan_after_filter q02 166.08 154.69 11.39 (7.36%)
shortest_path_ldbc100 q37 84.60 87.21 -2.61 (-2.99%)
shortest_path_ldbc100 q38 349.33 309.09 40.25 (13.02%)
shortest_path_ldbc100 q39 55.18 58.44 -3.26 (-5.58%)
shortest_path_ldbc100 q40 413.15 407.75 5.40 (1.32%)
var_size_expr_evaluator q03 2193.70 2084.76 108.94 (5.23%)
var_size_expr_evaluator q04 2209.85 2293.15 -83.30 (-3.63%)
var_size_expr_evaluator q05 2844.92 2725.40 119.52 (4.39%)
var_size_expr_evaluator q06 1401.02 1362.56 38.46 (2.82%)
var_size_seq_scan q19 1422.35 1430.70 -8.35 (-0.58%)
var_size_seq_scan q20 2638.80 2693.10 -54.30 (-2.02%)
var_size_seq_scan q21 2232.39 2258.50 -26.10 (-1.16%)
var_size_seq_scan q22 123.82 125.99 -2.17 (-1.72%)

@codecov Codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.28916% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.93%. Comparing base (1068d07) to head (5919ee5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/function/gds/gds.cpp 94.80% 4 Missing ⚠️
src/function/gds/k_core_decomposition.cpp 97.77% 1 Missing ⚠️
src/function/gds/page_rank.cpp 98.18% 1 Missing ⚠️
src/function/gds/strongly_connected_components.cpp 98.00% 1 Missing ⚠️
...ion/gds/strongly_connected_components_kosaraju.cpp 97.22% 1 Missing ⚠️
src/function/gds/weakly_connected_components.cpp 97.14% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5048      +/-   ##
==========================================
+ Coverage   87.92%   87.93%   +0.01%     
==========================================
  Files        1427     1416      -11     
  Lines       64565    64438     -127     
  Branches     7578     7569       -9     
==========================================
- Hits        56767    56664     -103     
+ Misses       7769     7745      -24     
  Partials       29       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andyfengHKU andyfengHKU mentioned this pull request Mar 14, 2025
Open
1 task
@andyfengHKU andyfengHKU merged commit 5cfad24 into master Mar 14, 2025
28 checks passed
@andyfengHKU andyfengHKU deleted the make-gds-table-func branch March 14, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

@acquamarin acquamarin acquamarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyfengHKU @ray6080 @acquamarin