Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Layer5-Leaderboard] Transfer of the Leaderboard Code to the discuss-board repo #29

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Kingscliq
Copy link

@Kingscliq Kingscliq commented Aug 8, 2023

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@leecalcote leecalcote added the kind/feature New major feature or request label Aug 8, 2023
Signed-off-by: Ananya Gautam <[email protected]>
Copy link
Member

@Boombag0607 Boombag0607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data alignment in the table component is not center.

leaderboard/src/components/elements/Table/index.tsx Outdated Show resolved Hide resolved
leaderboard/src/components/elements/Table/index.tsx Outdated Show resolved Hide resolved
leaderboard/src/features/Leaderboard/components/Header.tsx Outdated Show resolved Hide resolved
leaderboard/tailwind.config.js Show resolved Hide resolved
leaderboard/tailwind.config.js Outdated Show resolved Hide resolved
@thisiskaransgit
Copy link

Good Progress @Kingscliq, Let's discuss it on the website call. Let's add this as an agenda item in the meeting minutes.

@Boombag0607 @kayceeDev

@Chadha93
Copy link
Member

@Boombag0607 I'll help you get your suggested changes pushed in the same PR, will you demo it at today's meeting?

@@ -0,0 +1,25 @@
import path from 'path';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute paths. 👍

{title}
</div>
<div className="collapse-content px-0">
<div className="p-4 bg-white border border-[#E0E0E0] rounded-md">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are moving with a tailwind for styles lets also make it a theme-specific for discuss-board.

Copy link
Member

@Chadha93 Chadha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* [3 * number of solutions that was accepted from the user]
*
* */

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total Point logic.

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 15, 2023
@saurabh100ni saurabh100ni added issue/willfix This issue will be worked on and removed issue/stale Issue has not had any activity for an extended period of time labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on kind/feature New major feature or request
Development

Successfully merging this pull request may close these issues.

6 participants