Rd 783 e2e for animated route layer #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesbaa
changed the base branch from
main
to
RD-518/camera-helpers-and-better-maptraversal
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces e2e tests for the AnimatedRouteLayer feature and updates related configuration and helper files. Key changes include:
- Adding a new Vite config file for e2e testing.
- Enhancing the AnimatedRouteLayer with extended documentation and a new updateManual method.
- Creating various e2e test files and supporting helpers along with public HTML fixtures.
Reviewed Changes
Copilot reviewed 39 out of 44 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vite.config-e2e.ts | Sets up build inputs for e2e tests with minor naming details. |
| src/utils/MaptilerAnimation/types.ts | Adjusts type imports and enum definition for easing functions. |
| src/custom-layers/AnimatedRouteLayer.ts | Adds documentation, default assignments, and updateManual method. |
| playwright.config.ts | Introduces Playwright configuration for parallel e2e testing. |
| e2e/tests/* files | Provide e2e tests and helpers for map loading and layer animations. |
| e2e/src/* and e2e/public/* files | Include source and HTML fixtures for e2e testing. |
Files not reviewed (5)
- e2e/public/animated-route.geojson: Language not supported
- e2e/tests/expected-results/animatedRouteLayer-1.json: Language not supported
- e2e/tests/mocks/maptiler-style.json: Language not supported
- e2e/tsconfig.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
vite.config-e2e.ts:8
- The key 'animatedRoutLayer' appears to be missing an 'e'; consider renaming it to 'animatedRouteLayer' to maintain consistency with related file names.
animatedRoutLayer: "public/animatedRouteLayer.html",
sasaprodribaba
approved these changes
May 2, 2025
lesbaa
merged commit 497de82
into
RD-518/camera-helpers-and-better-maptraversal
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
To add minimal e2e testing for AnimatedRouteLayer
Description
Acceptance
Tests passing
Checklist
[ ] I have added relevant info to the CHANGELOG.mdN/A Until the feature branch is ready for release