Skip to content

Format signatures in LSP hover and completion documentation #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

krassowski
Copy link
Contributor

📝 Summary

🔍 Description of Changes

Adds pylsp_signatures_to_markdown hook, re-using existing ruff formatting utility.

Before After
image Screenshot from 2025-05-09 22-01-22

Note: this does not help with pd.read_csv; I am not sure why it is not hitting this code path, but notably it happens on the completion items which do not have a docstring either.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@mscolnick

Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 9:08am

@krassowski krassowski force-pushed the format-signatures branch from 1ab7ed2 to cdf2df7 Compare May 12, 2025 09:07
@mscolnick mscolnick marked this pull request as ready for review May 12, 2025 13:57
@mscolnick mscolnick merged commit 2eb2d6f into marimo-team:main May 12, 2025
24 of 33 checks passed
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.7-dev34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants