Improve docs on phpunit version #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCheesley
requested changes
Apr 23, 2024
| @@ -317,7 +317,9 @@ Mautic uses [PHPUnit][php-unit] and [Selenium][selenium] as the suite of testing | |||
|
|
|||
| #### PHPUnit | |||
|
|
|||
| Before executing unit tests, copy the `.env.dist` file to `.env` then update to reflect your local environment configuration. | |||
| **PHPUnit version:** Mautic 4.x requires [PHPUnit v5.7](https://phpunit.de/manual/5.7/en/installation.html), and Mautic 5.x requires [PHPUnit v9+](https://phpunit.de/announcements/phpunit-9.html). Make sure to install the right version of PHPUnit for the version of Mautic you are testing. | |||
There was a problem hiding this comment.
Could you please make these into link macros, as used in the rest of the doc and listed below at the bottom of the page? Thanks!
|
@pjrobertson could you review and act on the feedback here please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the developer docs still link to phpunit5.7, which is very old. I changed to reference phpunit 9+
I guess all this could perhaps be removed to just say "use composer update" ??
Edit: It would also be nice to know how to run the
phpunittests on the gitpod servers. I tried and it didn't seem to work. I also couldn't get it working locally, even after watching https://www.youtube.com/watch?v=fqnT3kaDaW4