Add support for argo workflow targets #3287
Conversation
…dd-support-for-argo-workflow-targets
| @@ -157,7 +165,7 @@ impl TargetType { | |||
| Self::Pod => !(config.copy_target.enabled && config.copy_target.scale_down), | |||
| Self::Job | Self::CronJob => config.copy_target.enabled, | |||
| Self::Service => !config.copy_target.enabled, | |||
| Self::Deployment | Self::StatefulSet | Self::ReplicaSet => true, | |||
| Self::Deployment | Self::StatefulSet | Self::ReplicaSet | Self::Workflow => true, | |||
There was a problem hiding this comment.
How come workflow targets don't require a copy_target? Since they actually target a specific node of the workflow graph that ends, like a job?
There was a problem hiding this comment.
I'm a bit hesitant in requiring it being copy-target just yet because of the amount of customization included in workflows, Right now we can add support for "catching" a running workflow
There was a problem hiding this comment.
Missing user-facing docs for workflow targets.
Also, we might want to clarify the container/... part of the target in those docs, because people might assume that part means - choose a template with that container name, but it doesn't, with the current code what it means is - once you found the pod that was created for the target template, choose this container of that pod.
No description provided.