Skip to content

Changed name of the operator feature for kafka splitting without copy #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/+kafka-splitting-copy-target.fixed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed logic for detecting whether the operator supports Kafka splitting without copying the target.
2 changes: 1 addition & 1 deletion mirrord/operator/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ impl OperatorApi<PreparedClientCert> {
&& self
.operator()
.spec
.require_feature(NewOperatorFeature::KafkaQueueSplittingNoCopy)
.require_feature(NewOperatorFeature::KafkaQueueSplittingDirect)
.is_err());
let (connect_url, session_id) = if do_copy_target {
let mut copy_subtask = progress.subtask("copying target");
Expand Down
4 changes: 2 additions & 2 deletions mirrord/operator/src/crd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ pub enum NewOperatorFeature {
SqsQueueSplitting,
KafkaQueueSplitting,
LayerReconnect,
KafkaQueueSplittingNoCopy,
KafkaQueueSplittingDirect,
/// This variant is what a client sees when the operator includes a feature the client is not
/// yet aware of, because it was introduced in a version newer than the client's.
#[schemars(skip)]
Expand All @@ -293,7 +293,7 @@ impl Display for NewOperatorFeature {
NewOperatorFeature::SqsQueueSplitting => "SQS queue splitting",
NewOperatorFeature::KafkaQueueSplitting => "Kafka queue splitting",
NewOperatorFeature::LayerReconnect => "layer reconnect",
NewOperatorFeature::KafkaQueueSplittingNoCopy => {
NewOperatorFeature::KafkaQueueSplittingDirect => {
"Kafka queue splitting without copy target"
}
NewOperatorFeature::Unknown => "unknown feature",
Expand Down
Loading