Skip to content

Add apple targets to cargo-deny #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ jobs:
.dockerignore
rust-toolchain.toml
rustfmt.toml
deny.toml
.cargo/**
- name: get markdown changes
id: changed-markdown
Expand Down
1 change: 1 addition & 0 deletions changelog.d/+add-apple-deny.internal.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add `x86_64-apple-darwin` and `aarch64-apple-darwin` as targets for cargo-deny check.
7 changes: 7 additions & 0 deletions deny.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
[graph]
targets = [
"x86_64-apple-darwin",
"x86_64-unknown-linux-gnu",
"aarch64-apple-darwin",
"aarch64-unknown-linux-gnu",
]
all-features = true

[advisories]
version = 2
ignore = [
"RUSTSEC-2020-0095", # difference is unmaintained. (part of apple-codesign)
"RUSTSEC-2023-0071", # rsa crate, potential key recovery through timing sidechannels, though it sounds bad
# we only use rsa as part of apple-codesign for re-sign binaries, so this should not matter.
"RUSTSEC-2024-0436", # paste is unmaintained but we should not have an issue with it.
]

Expand All @@ -16,6 +21,8 @@ version = 2
allow = [
"Apache-2.0 WITH LLVM-exception",
"Apache-2.0",
"BlueOak-1.0.0",
"BSL-1.0",
"BSD-2-Clause",
"BSD-3-Clause",
"CC0-1.0",
Expand Down
Loading