[Scripts] Add dense baseline evaluation scripts. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Microsoft" |
YizhaoGao
reviewed
Apr 25, 2025
There was a problem hiding this comment.
why eos_token_ids can be a list
YizhaoGao
reviewed
Apr 25, 2025
There was a problem hiding this comment.
can you clean up comments in the arguments
YizhaoGao
reviewed
Apr 25, 2025
eval/reasoning_tasks/eval.py
Outdated
| total_activate_count, total_original_count, overall_sparsity_ratio = calculate_overall_sparsity(all_batch_sparsitys_info) | ||
| print("Overall_sparsity: ", overall_sparsity_ratio) | ||
|
|
||
| with open(f"./completions_{args.rank}.json", 'w') as f: |
There was a problem hiding this comment.
change output file name in the output folder instead of ./
YizhaoGao
reviewed
Apr 25, 2025
eval/reasoning_tasks/eval.py
Outdated
| "total_time": total_time, | ||
| } | ||
|
|
||
| with open(f"./others_{args.rank}.json", 'w') as f: |
There was a problem hiding this comment.
change output file name in the output folder instead of ./
YizhaoGao
reviewed
Apr 25, 2025
eval/reasoning_tasks/eval.py
Outdated
| parser.add_argument("--attention_implementation", default="seer_sparse", choices=["seer_sparse", "oracle_sparse", "fa2", "sdpa"], type=str) | ||
| parser.add_argument("--use_batch_exist", action="store_true") | ||
| parser.add_argument("--attention_implementation", default="seer_sparse", choices=["seer_sparse", "seer_dense", "oracle_sparse", "fa2", "sdpa"], type=str) | ||
| parser.add_argument("--use_batch_exist", default=1, type=int) |
There was a problem hiding this comment.
change the type to bool and use true and false instead of 0 1
YizhaoGao
reviewed
Apr 25, 2025
eval/reasoning_tasks/get_results.py
Outdated
| examples = examples * args.repeat | ||
|
|
||
|
|
||
| with open(f"./completions_{args.rank}.json", 'r') as f: |
There was a problem hiding this comment.
change the output dir of completion and others
YizhaoGao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.