Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy strict without optional dependencies #246

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Mypy strict without optional dependencies #246

merged 4 commits into from
Dec 4, 2023

Conversation

mat-sop
Copy link
Contributor

@mat-sop mat-sop commented Dec 4, 2023

This pr fixes base clients to pass mypy --strict without optional dependencies installed.

@mat-sop mat-sop self-assigned this Dec 4, 2023
@mat-sop mat-sop marked this pull request as draft December 4, 2023 11:23
@mat-sop mat-sop force-pushed the mypy_strict_without_optional branch from 977ba1f to 3c02e01 Compare December 4, 2023 11:25
@rafalp
Copy link
Contributor

rafalp commented Dec 4, 2023

Does this PR resolve #219?

@mat-sop
Copy link
Contributor Author

mat-sop commented Dec 4, 2023

Does this PR resolve #219?

Yes, it resolves #219

@mat-sop mat-sop marked this pull request as ready for review December 4, 2023 11:28
@mat-sop mat-sop requested a review from rafalp December 4, 2023 11:28
@mat-sop mat-sop merged commit a30d1b0 into main Dec 4, 2023
4 checks passed
@mat-sop mat-sop deleted the mypy_strict_without_optional branch December 4, 2023 12:23
@rafalp rafalp mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalp rafalp rafalp approved these changes

Assignees

@mat-sop mat-sop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mat-sop @rafalp