Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise GraphQLClientGraphQLMultiError instead of GraphQLClientInvalidResponseError #248

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Raise GraphQLClientGraphQLMultiError instead of GraphQLClientInvalidResponseError #248

merged 2 commits into from
Dec 4, 2023

Conversation

mat-sop
Copy link
Contributor

@mat-sop mat-sop commented Dec 4, 2023

This pr changes base clients to raise GraphQLClientGraphQLMultiError instead of GraphQLClientInvalidResponseError for payloads with errors key but without data.

resolves #240

@mat-sop
Change base clients to raise GraphQLClientGraphQLMultiError instead o…
5bfd63c 
…f GraphQLClientInvalidResponseError for payloads with errors key and no data.
@mat-sop
Update changelog
b9275a6
@mat-sop mat-sop self-assigned this Dec 4, 2023
@mat-sop mat-sop requested a review from rafalp December 4, 2023 14:56
@mat-sop mat-sop merged commit ceafcd9 into main Dec 4, 2023
4 checks passed
@mat-sop mat-sop deleted the exception_only_errors_key branch December 4, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalp rafalp rafalp approved these changes

Assignees

@mat-sop mat-sop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: GraphQL spec does not mandate that "data" is always returned
2 participants
@mat-sop @rafalp