Add scalar to Operation plugin client test #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mat-sop! First, I want to thank you for this library; it has helped me a lot in my work, and I would be glad to provide any help in developing.
I found and fixed by myself the same issue as in PR 256. Trying to use get_client_settings in a plugin raises a TypeError. Although @slessans has already addressed this issue, I believe adding a test for this fix would be beneficial. I've updated the ExtractOperationsPlugin client test by including a scalar to verify the fix.
If there's anything I can do better, please let me know.