Remove crypto browserify library #8355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using the browser crypto library makes sense. It's a small change, but as the bundle size drops, it should result in a visible performance improvement. |
|
Yep! Moving towards native methods will definitely help. Moment and lodash are also on the chopping block. |
|
Passes the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes a step further than #8329 and instead uses the browser's native crypto library, or the node built-in for serverside.
This results in a bundle reduction of 0.87mb.
All tests are still passing. I opted not to change the SHA1 encoding- I saw that there's a SHA512 secret in enclave.js, so I assume that sha1 wasn't used just for lack of knowledge about its lack of cryptographic security?