imapnotify: add wait option to imapnotify-accounts
#6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
starting from what version ? is that in unstable yet ? |
|
I've encountered this problem on goimapnotify 2.4, which is the current version for both nixos-24.11 and nixpkgs-unstable. |
|
An |
|
Good idea. Going to implement it like it is on the swayidle module.
… An `extraArgs` like in modules/services/swayidle.nix would be more generic.
--
Reply to this email directly or view it on GitHub:
#6369 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
`wait` is no longer a part of the goimapnotify's config, but one of its cli options.
onemoresuza
force-pushed
the
imapnotify-wait-opt
branch
from
6168b2d to
191d566
Compare
teto
reviewed
Feb 4, 2025
| @@ -30,10 +30,15 @@ with lib; | |||
| description = "IMAP folders to watch."; | |||
| }; | |||
|
|
|||
| extraArgs = mkOption { | |||
| type = types.listOf types.str; | |||
| default = [ "-wait 1" ]; | |||
There was a problem hiding this comment.
the current module doesn't seem to set wait at all. Can we keep this behavior and use "-wait 1" as an example instead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
waitis no longer a part of the goimapnotify's config, but one of itscli options.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@NickHu