Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: correct vendorPath of firefox forks #6421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mikilio
Copy link
Contributor

@Mikilio Mikilio commented Feb 9, 2025

Description

The path for messaging hosts seems to have been
~/.mozilla/native-messaging-hosts/ all along.
This PR fixes that
Solves #5190

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@bricked

@Mikilio
Copy link
Contributor Author

Mikilio commented Feb 9, 2025

The failure is completely unrelated to this PR

@Mikilio Mikilio changed the title fix(firefox) correct vendorPath of firefox forks firefox: correct vendorPath of firefox forks Feb 9, 2025
Copy link
Contributor

@brckd brckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense that the config path and vendor path shouldn't be the same. As you already mentioned, we should check whether this change actually works for both LibreWolf and Floorp browser.

modules/programs/floorp.nix Outdated Show resolved Hide resolved
@brckd
Copy link
Contributor

brckd commented Feb 9, 2025

I also noticed that LibreWolf's config and vendor paths on Darwin are the same as well. That can't be right. We should test whether we can use Mozila's vendor path as well, or otherwise remove that declaration.

platforms.darwin = {
vendorPath = "Library/Application Support/LibreWolf";
configPath = "Library/Application Support/LibreWolf";
};

@Mikilio
Copy link
Contributor Author

Mikilio commented Feb 10, 2025

Unfortunately I don't have a Mac and quickemu isn't doing it's thing for me.
But I have a suspicion it's always going to be /Library/Application Support/Mozilla/ because that is the path one of my favorite extensions installs the native-messenger to. https://raw.githubusercontent.com/tridactyl/native_messenger/master/installers/install.sh

The path for messaging hosts seems to have been
~/.mozilla/native-messaging-hosts/ and ~/Library/Application Support/Mozilla so vendorPath has been adjusted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants