Backport #6253 and #6332 #6423
Open
Backport #6253 and #6332 #6423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add `Unit.After`.
Also add `ConditionEnvironment`.
Also add `ConditionEnvironment`.
Also add `ConditionEnvironment`.
Also add missing `ConditionEnvironment`.
…#6332) Create a internal/read-only trayTarget option for the xsession, which is also used in wayland's config, if the former is not enabled. Remove all other definitions of `systemd.user.targets.tray`, i. e, the ones from the following modules: hyprland, sway, river and wayfire.
lordkekz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6253 (standardize wayland graphical services) and #6332 (create tray.target if xsession is not enabled).
IMO this should be backported because it fixes a common activation failure, which impacted other activation steps like stylix.
The first PR was already backwards compatible, I merely removed a change for a module that isn't in stable.
The second PR wasn't initially backwards compatible, but I added
lib.mkDefaultto ensure that configurations with the workaround discussed in #2064 still work.Feel free to reject it if you don't want this backported.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC